Back to the main page.

Bug 2996 - filter_with_correction is not up to date in specest

Status CLOSED FIXED
Reported 2015-10-30 16:18:00 +0100
Modified 2016-06-14 16:14:49 +0200
Product: FieldTrip
Component: specest
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P5 normal
Assigned to: Robert Oostenveld
URL:
Tags:
Depends on:
Blocks:
See also:

Vladimir Litvak - 2015-10-30 16:18:28 +0100

I got a bug report from a colleague with the following error: Error using filter_with_correction Too many input arguments. In file "E:\Dropbox\spm\spm12\spm12\external\fieldtrip\specest\private\ft_preproc_bandpassfilter.m" (v10291), function "ft_preproc_bandpassfilter" at line 283. In file "E:\Dropbox\spm\spm12\spm12\external\fieldtrip\specest\ft_specest_hilbert.m" (v10307), function "ft_specest_hilbert" at line 171. In file "E:\Dropbox\spm\spm12\spm12\spm_eeg_specest_hilbert.m" (v4463), function "spm_eeg_specest_hilbert" at line 120. This comes down to the fact that filter_with_correction version in specest/private is different from that in preproc/private but the version of ft_preproc_bandpassfilter in specest/private is up to date and tries to call filter_with_correction with more arguments than that old version expects. Please fix. Thanks, Vladimir


Robert Oostenveld - 2015-11-04 17:51:55 +0100

mac011> svn log specest/private/filter_with_correction.m r7123 | roboos | 2012-12-06 22:21:38 +0100 (Thu, 06 Dec 2012) | 2 lines ... mac011> svn log preproc/private/filter_with_correction.m r9991 | jansch | 2014-12-01 17:03:02 +0100 (Mon, 01 Dec 2014) | 1 line ... So the one in specest is older. The auto sync property has not been set on either. mac011> cp preproc/private/filter_with_correction.m specest/private/ mac011> svn propset autosync true */private/filter_with_correction.m property 'autosync' set on 'preproc/private/filter_with_correction.m' property 'autosync' set on 'specest/private/filter_with_correction.m' mac011> svn commit */private/filter_with_correction.m Sending preproc/private/filter_with_correction.m Sending specest/private/filter_with_correction.m Transmitting file data . Committed revision 10840.


Robert Oostenveld - 2016-06-14 16:14:49 +0200

Hereby I am closing multiple bugs that have been resolved for some time now. If you don't agree to the resolution, please reopen.