Back to the main page.

Bug 3004 - making cfg.trialdef.eventtype = '?' the default

Reported 2015-11-13 14:21:00 +0100
Modified 2016-06-17 15:57:12 +0200
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P5 enhancement
Assigned to: Jan-Mathijs Schoffelen
Depends on:
See also:

Jörn M. Horschig - 2015-11-13 14:21:27 +0100

How about making cfg.trialdef.eventtype = '?' the default, e.g. when someone who has not been using FT in a while forgets to set cfg.trialdef at all? would have been handy and saved me a few seconds of my time ;)

Jörn M. Horschig - 2015-11-13 14:33:42 +0100

btw, I would even implement this :o) but no hard feelings if you don't like it!

Robert Oostenveld - 2015-11-16 11:41:55 +0100

eventtype=? only applies to ft_trialfun_general (which is also the default). So this would not apply if someone specifies an explicit trialfun. The idea might be that if trialfun and trialdef are both empty, that it would print a report. Should we consider moving this from ft_trialfun_general to ft_trialfun_report? Does this not interfere with making a single long (continuous) data segment? I know that if I now do cfg = []; cfg.dataset = something continuous ft_preprocessing(cfg) I get a single continuous segment (and no errors or warnings). What would happen now if I do this cfg = []; cfg.dataset = something continuous cfg = ft_definetrial(cfg) data = ft_preprocessing(cfg) and what would we want to happen?

Jan-Mathijs Schoffelen - 2016-06-09 21:57:58 +0200

(In reply to Jörn M. Horschig from comment #1) Since Jörn won't be offended, I suggest not to do this, also based om Robert's comment #2. Let's close.