Back to the main page.
Bug 3060 - ANT EEProbe: new files not supported
| Status | CLOSED FIXED |
| Reported | 2016-02-02 21:10:00 +0100 |
| Modified | 2019-08-10 12:32:24 +0200 |
| Product: | FieldTrip |
| Component: | fileio |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Windows |
| Importance: | P5 blocker |
| Assigned to: | |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
François Tadel - 2016-02-02 21:10:59 +0100
Newer files cannot be imported properly (read_eep_cnt crashes). Version currently in fileio: libeep-3.3.167 Version currently distributed by ANT: libeep-3.3.173 https://www.ant-neuro.com/support/supporting-documentation-and-downloads Just updating the library fixes the problem.
Robert Oostenveld - 2016-02-03 09:50:29 +0100
Hi Francois, You mean that we should update fieldtrip/external/eeprobe to the files that can be downloaded from their site? Do you have a demo file in the new format? ANT has ben notoriously bad in supporting this. I initially (long time ago when the company was just started) wrote the mex wrappers and donated them to ANT under a BSD license. Since then, it keeps getting back on my plate to support their data. The consequence is that I am not too enthusiastic about supporting it any more, also because we don't have their systems in Nijmegen.
François Tadel - 2016-02-03 14:47:34 +0100
Example file: https://www.dropbox.com/s/k3n7x9wa2g4v1vm/ANT_newfiles.zip?dl=0 There is not much to do, just download the new mex files (maybe just read_eep_cnt): http://download.ant-neuro.com/matlab/ I guess they linked your old mex code against their new libeep library. The associated .m files still say "Copyright 2002, Robert Oostenveld" :)
Robert Oostenveld - 2016-02-03 17:18:53 +0100
(In reply to François Tadel from comment #2) thanks, got them. For reference: the zip file contained mac011> unzip ANT_newfiles.zip Archive: ANT_newfiles.zip inflating: 289_ILD_1_10012015.cnt inflating: 289_ILD_1_10012015.evt inflating: 289_ILD_1_10012015.sen inflating: 289_ILD_1_10012015.trg and I copied them to /home/common/matlab/fieldtrip/data/test/original/eeg/eeprobe From the list Windows 32 bit : libeep-3.3.173.zip April 2015 Windows 64 bit : libeep-3.3.173.zip April 2015 Linux 64 bit : libeep-3.3.173.tar.gz April 2015 Linux(CentOS 6.5) 64 bit : libeep-3.3.173-centos65.tar.gz April 2015 MacOSX 64 bit : libeep-3.3.173.tar.gz April 2015 I will take all, except for the 64-bit centos65. The other 64 bit linux sounds more generic.
Robert Oostenveld - 2016-02-03 17:44:38 +0100
(In reply to Robert Oostenveld from comment #3) Ok, this won't go through SVN any more (see bug 3049). Therefore I'll first push it to a personal branch and then have than merged with upstream. mac011> git commit [bug3060-eeprobe aa62a55] ENH - updated to the latest version of the mex files from ANT, see http://bugzilla.fieldtriptoolbox.org/show_bug.cgi?id=3060 26 files changed, 9 insertions(+), 4 deletions(-) ... mac011> git push --all X11 forwarding request failed on channel 0 Counting objects: 129, done. Delta compression using up to 4 threads. Compressing objects: 100% (44/44), done. Writing objects: 100% (47/47), 377.56 KiB | 0 bytes/s, done. Total 47 (delta 36), reused 3 (delta 3) To git@github.com:robertoostenveld/fieldtrip.git * [new branch] bug3060-eeprobe -> bug3060-eeprobe * [new branch] pull73 -> pull73 * [new branch] pull74 -> pull74
Robert Oostenveld - 2016-02-04 12:11:09 +0100
I pulled it through github. See https://github.com/fieldtrip/fieldtrip/pull/75 If you want, you can from now on directly make suggestions to the code on github and send pull requests. I guess we'll continue using bugzilla as well (besides github issues). thanks