Back to the main page.

Bug 3165 - ft_prepare_layout doesn't work anymore with integer coordinates

Status CLOSED FIXED
Reported 2016-07-22 09:46:00 +0200
Modified 2016-11-29 09:00:45 +0100
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: All
Importance: P5 minor
Assigned to: Jan-Mathijs Schoffelen
URL:
Tags:
Depends on:
Blocks:
See also:

Joscha Schmiedt - 2016-07-22 09:46:43 +0200

Since the changes for Octave compatibility (commit a297d505daa7e817a77f3fb6625c16acd84aed68) it is not possible anymore to use integer coordinates. The regexp expects floating numbers. https://github.com/fieldtrip/fieldtrip/commit/a297d505daa7e817a77f3fb6625c16acd84aed68#diff-d11c009e8e93adb6dabb78d2ebd1b4b7


Joscha Schmiedt - 2016-07-22 09:53:07 +0200

Created attachment 802 test layout file And the label must not contain hyphens.


Jan-Mathijs Schoffelen - 2016-08-08 14:21:13 +0200

It seems to be a problem related to the hyphens


Jan-Mathijs Schoffelen - 2016-08-08 14:48:48 +0200

I am not too familiar with regular expressions, but adding a \- in the channel_label variable (as introduced by Nikolaas) should do the trick. Agreed? If so, I'll update the master branch on github accordingly.


nno - 2016-08-08 16:22:13 +0200

(In reply to Jan-Mathijs Schoffelen from comment #3) Thanks Jan-Mathijs and Joscha for reporting this. Indeed it would seem that adding a hyphen through '\-' would add support for labels with hyphens. best, Nick


Jan-Mathijs Schoffelen - 2016-08-09 09:43:26 +0200

OK, done. @Joscha: note that in general we would nowadays recommend using layouts specified in a mat-file, which allows for more flexible outlines (in particular preventing the creation of the in your example layout silly circular head with ears and nose), and masks.