Back to the main page.

Bug 3194 - prepare_mesh_hexahedral uses .pnt instead of .pos

Status ASSIGNED
Reported 2016-10-27 10:07:00 +0200
Modified 2016-10-27 10:23:24 +0200
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: Mac OS
Importance: P5 normal
Assigned to: Robert Oostenveld
URL:
Tags:
Depends on:
Blocks:
See also:

Simon - 2016-10-27 10:07:07 +0200

prepare_mesh_hexahedral uses .pnt instead of .pos I recalled a bug where the switch from .pnt to .pos was discussed, but I couldn't find it through the search. Thus far we somehow dealt with it with fixpos. Does this still apply?


Robert Oostenveld - 2016-10-27 10:19:23 +0200

fixpos is only meant to fix the input that the functions get, as that might be coming from a user script or an old file stored on disk. The code itself should not use put any more.


Simon - 2016-10-27 10:21:33 +0200

(In reply to Robert Oostenveld from comment #1) Ok, sounds reasonable. I change .pnt to .pos in the code then.


Robert Oostenveld - 2016-10-27 10:23:24 +0200

With mac011> grep -l put fieldtrip/*.m and mac011> grep -l put fieldtrip/private/*.m I see that there are still many more functions that use pnt. If we slowly change the code (testing it every time), then perhaps in a year form now we'll have pos throughout. Please go ahead and send a PR.