Back to the main page.
Bug 320 - ft_spike_sub_crossx.mexmaci should not be in main directory
| Status | CLOSED FIXED |
| Reported | 2010-12-17 09:15:00 +0100 |
| Modified | 2011-12-10 11:38:44 +0100 |
| Product: | FieldTrip |
| Component: | spike |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | All |
| Importance: | P1 enhancement |
| Assigned to: | Martin Vinck |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Robert Oostenveld - 2010-12-17 09:15:41 +0100
probably it should be in fieldtrip/private. It also has to be added to th eft_compile_mex script and binaries for the other platforms shoudl be provided.
Robert Oostenveld - 2010-12-17 09:16:07 +0100
and it needs a m-file with the help, and potentially auto-compilation
Robert Oostenveld - 2011-04-27 20:55:26 +0200
changed multiple bugs that already had names attached from NEW into ASSIGNED. If you (as the assignee) don't agree, please reassign it to fieldtrip-bugs and change the status back into NEW.
Martin Vinck - 2011-11-27 22:22:15 +0100
when we move the spike functions to contrib this should not be in fieldtrip/private, but in contrib/spike/private, correct? I can compile for windows 32 and make autocompilation script but don't have a working version windows 64 for windows with mex utility to compile it
Robert Oostenveld - 2011-11-28 09:09:59 +0100
(In reply to comment #3) It should indeed move to fieldtrip/contrib/spike/private eventually, but at the moment the appropriate location is fieldtrip/private. I suggest to move all of ft_spike_sub_crossx to fieldtrip/private for the moment, and in two weeks or so (when contrib is ready) it can be moved to its final location. Since there is a compiled version for win64 already, there is no actual need to recompile. But please do create an autocompile script. Here is a suggestion (based on the other autocompile scripts) %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% function [varargout] = ft_spike_sub_crossx(varargin) % FT_SPIKE_SUB_CROSSX explain the function % % Use as % explain the usage % % Note that this function is implemented as a mex file. If the mex file is % missing on your platform, it will make an attempt to automatically % compile it % remember the original working directory pwdir = pwd; % determine the name and full path of this function funname = mfilename('fullpath'); mexsrc = [funname '.c']; [mexdir, mexname] = fileparts(funname); try % try to compile the mex file on the fly warning('trying to compile MEX file from %s', mexsrc); cd(mexdir); mex(mexsrc); cd(pwdir); success = true; catch % compilation failed disp(lasterr); error('could not locate MEX file for %s', mexname); cd(pwdir); success = false; end if success % execute the mex file that was juist created funname = mfilename; funhandle = str2func(funname); [varargout{1:nargout}] = funhandle(varargin{:}); end
Martin Vinck - 2011-11-28 13:27:17 +0100
ok will take care of that move then including the autocompilation script