Back to the main page.
Bug 3254 - ft_sourceplot does not initialise ft_progress based on cfg.feedback
| Status | CLOSED FIXED |
| Reported | 2017-02-16 16:51:00 +0100 |
| Modified | 2019-08-10 12:41:08 +0200 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | Macintosh |
| Operating System: | Mac OS |
| Importance: | P5 enhancement |
| Assigned to: | Robert Oostenveld |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Anne Urai - 2017-02-16 16:51:18 +0100
When using cfg.rawtrial in ft_sourceanalysis, ft_progress is initialised (line 660) ft_progress('init', 'text') without any user-defined cfg.feedback. Changing this to ft_progress('init', cfg.feedback, 'processing trials') would enable the user to reduce the single-trial output.
Robert Oostenveld - 2017-02-17 10:01:35 +0100
Thanks for the suggestion. Searching through the code, I found three more cases where this applies ft_componentanalysis.m: ft_progress('init', 'text', 'computing kernel matrix...'); ft_interpolatenan.m:ft_progress('init', 'etf'); ft_scalpcurrentdensity.m: ft_progress('init', 'text'); ft_sourceanalysis.m: ft_progress('init', 'text');
Robert Oostenveld - 2017-02-17 10:03:14 +0100
[master be9fe2b] ENH - use cfg.feedback as suggested by Anne in http://bugzilla.fieldtriptoolbox.org/show_bug.cgi?id=3254. Also inproved the cfg handling in ft_interpolatenan, the output cfg is now properly updated. 4 files changed, 30 insertions(+), 24 deletions(-) mac011> git push upstream master You're about to push master, is that what you intended? [y|n] y Counting objects: 6, done. Delta compression using up to 4 threads. Compressing objects: 100% (6/6), done. Writing objects: 100% (6/6), 1.32 KiB | 0 bytes/s, done. Total 6 (delta 5), reused 0 (delta 0) remote: Resolving deltas: 100% (5/5), completed with 5 local objects. To github.com:fieldtrip/fieldtrip.git ce799c4..be9fe2b master -> master
Robert Oostenveld - 2019-08-10 12:34:57 +0200
This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue on https://github.com/fieldtrip/fieldtrip/issues.