Back to the main page.

Bug 3268 - make a consistent interface to the functions that return spherical meshes

Status CLOSED FIXED
Reported 2017-03-11 10:58:00 +0100
Modified 2019-04-19 12:33:41 +0200
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: Mac OS
Importance: P5 minor
Assigned to: Jan-Mathijs Schoffelen
URL:
Tags:
Depends on:
Blocks:
See also:

Robert Oostenveld - 2017-03-11 10:58:06 +0100

inside ft_prepare_mesh there is a make sphere subfunction. It would be good to make that a stand-alone private function with the name "sphere", and replace all occurrences of icosahedronXXX with a call to that function. That would make it similar to the plotting/private/cylinder function.


Jan-Mathijs Schoffelen - 2019-03-29 21:06:17 +0100

hmmm, both sphere and cylinder are matlab functions, that do not return pos/tri meshes, but a set of x/y/z coordinates. I think it would be good to rename cylinder into cylinder_mesh, and to create a sphere_mesh function that will overtake the icosahedra.


Robert Oostenveld - 2019-04-01 10:39:36 +0200

+1


Jan-Mathijs Schoffelen - 2019-04-02 10:39:07 +0200

done and merged (apart from the cylinder_mesh rename);