Back to the main page.
Bug 3284 - regression tests failing for older MATLAB versions
| Status | CLOSED FIXED |
| Reported | 2017-04-20 13:38:00 +0200 |
| Modified | 2019-08-10 12:41:16 +0200 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Mac OS |
| Importance: | P5 normal |
| Assigned to: | |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Robert Oostenveld - 2017-04-20 13:38:51 +0200
I ran the dashboard batch for MATLAB versions 2011a up to 2017a. After weeding out two obvious failures, I am left with this list of test scripts. These don't fail in 2016a, 2016b or 2017a. With this http://www.fieldtriptoolbox.org/development/guidelines/code#ensure_that_it_runs_on_older_matlab_versions in mind, we should fix the code so that it works at least from 2012b onward. fa0dba5-R2011a/test_bug1114.txt:=== test_bug1114 FAILED in 4 seconds fa0dba5-R2011a/test_bug2093.txt:=== test_bug2093 FAILED in 983 seconds fa0dba5-R2011a/test_bug2338.txt:=== test_bug2338 FAILED in 24 seconds fa0dba5-R2011a/test_bug2524.txt:=== test_bug2524 FAILED in 1 seconds fa0dba5-R2011a/test_bug2569.txt:=== test_bug2569 FAILED in 3 seconds fa0dba5-R2011a/test_channelconnectivity.txt:=== test_channelconnectivity FAILED in 0 seconds fa0dba5-R2011a/test_dependencies.txt:=== test_dependencies FAILED in 4 seconds fa0dba5-R2011a/test_ft_plot_cloud.txt:=== test_ft_plot_cloud FAILED in 2 seconds fa0dba5-R2011a/test_ft_prepare_layout.txt:=== test_ft_prepare_layout FAILED in 25 seconds fa0dba5-R2011b/test_bug1114.txt:=== test_bug1114 FAILED in 5 seconds fa0dba5-R2011b/test_bug2093.txt:=== test_bug2093 FAILED in 503 seconds fa0dba5-R2011b/test_bug2524.txt:=== test_bug2524 FAILED in 0 seconds fa0dba5-R2011b/test_bug2569.txt:=== test_bug2569 FAILED in 3 seconds fa0dba5-R2011b/test_bug2990.txt:=== test_bug2990 FAILED in 31 seconds fa0dba5-R2011b/test_dependencies.txt:=== test_dependencies FAILED in 5 seconds fa0dba5-R2011b/test_ft_movieplotTFR.txt:=== test_ft_movieplotTFR FAILED in 16 seconds fa0dba5-R2011b/test_ft_plot_cloud.txt:=== test_ft_plot_cloud FAILED in 1 seconds fa0dba5-R2011b/test_ft_prepare_layout.txt:=== test_ft_prepare_layout FAILED in 25 seconds fa0dba5-R2012a/test_bug2093.txt:=== test_bug2093 FAILED in 504 seconds fa0dba5-R2012a/test_bug2338.txt:=== test_bug2338 FAILED in 23 seconds fa0dba5-R2012a/test_bug2569.txt:=== test_bug2569 FAILED in 2 seconds fa0dba5-R2012a/test_ft_movieplotTFR.txt:=== test_ft_movieplotTFR FAILED in 7 seconds fa0dba5-R2012a/test_ft_plot_cloud.txt:=== test_ft_plot_cloud FAILED in 3 seconds fa0dba5-R2012a/test_ft_prepare_layout.txt:=== test_ft_prepare_layout FAILED in 28 seconds fa0dba5-R2012b/test_bug2093.txt:=== test_bug2093 FAILED in 632 seconds fa0dba5-R2012b/test_bug2338.txt:=== test_bug2338 FAILED in 27 seconds fa0dba5-R2012b/test_ft_movieplotTFR.txt:=== test_ft_movieplotTFR FAILED in 8 seconds fa0dba5-R2012b/test_ft_plot_cloud.txt:=== test_ft_plot_cloud FAILED in 1 seconds fa0dba5-R2012b/test_ft_prepare_layout.txt:=== test_ft_prepare_layout FAILED in 38 seconds fa0dba5-R2013a/test_bug2093.txt:=== test_bug2093 FAILED in 970 seconds fa0dba5-R2013a/test_bug2338.txt:=== test_bug2338 FAILED in 34 seconds fa0dba5-R2013a/test_ft_movieplotTFR.txt:=== test_ft_movieplotTFR FAILED in 17 seconds fa0dba5-R2013a/test_ft_plot_cloud.txt:=== test_ft_plot_cloud FAILED in 2 seconds fa0dba5-R2013a/test_ft_prepare_layout.txt:=== test_ft_prepare_layout FAILED in 29 seconds fa0dba5-R2013b/test_ft_movieplotTFR.txt:=== test_ft_movieplotTFR FAILED in 8 seconds fa0dba5-R2013b/test_ft_prepare_layout.txt:=== test_ft_prepare_layout FAILED in 17 seconds fa0dba5-R2014a/test_ft_movieplotTFR.txt:=== test_ft_movieplotTFR FAILED in 8 seconds fa0dba5-R2014a/test_ft_prepare_layout.txt:=== test_ft_prepare_layout FAILED in 29 seconds fa0dba5-R2014b/test_ft_movieplotTFR.txt:=== test_ft_movieplotTFR FAILED in 15 seconds fa0dba5-R2015a/test_ft_movieplotTFR.txt:=== test_ft_movieplotTFR FAILED in 16 seconds fa0dba5-R2015b/test_bug3196.txt:=== test_bug3196 FAILED in 22 seconds
Robert Oostenveld - 2017-04-20 14:31:35 +0200
I have created a (personal) branch to make changes. I started with 2012b: test_bug2338 has to do with numerical precision. Replacing sequel with isalmostequal resolves the issue. test_ft_plot_cloud has to do with the parula colormap. test_ft_prepare_layout has to do with "axis tight", it is a MATLAB error (3D feature of figure not recognized?). Don't know how to solve. test_ft_movieplotTFR works fine (when interactive in 2012b) I suspect all others to be due to numerical issues. in 2011b I found the following: test_bug1114 is due to a compat function for isequaln. This is not an error, but it is fine that 1114 detected it. test_bug2524 fails to run the FLS binary. test_bug2569 is an error due to bitand missing for signed int32 in case of wdq data. That is too obscure to bother with.
Robert Oostenveld - 2017-04-20 14:33:43 +0200
I merged the changes into the master. See https://github.com/fieldtrip/fieldtrip/pull/409 That should be enough for now.
Robert Oostenveld - 2019-08-10 12:35:05 +0200
This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue on https://github.com/fieldtrip/fieldtrip/issues.