Back to the main page.

Bug 3287 - revise the implementation of the ft_append functions

Status	CLOSED FIXED
Reported	2017-04-21 14:08:00 +0200
Modified	2019-08-10 12:41:02 +0200
Product:	FieldTrip
Component:	core
Version:	unspecified
Hardware:	PC
Operating System:	Mac OS
Importance:	P5 normal
Assigned to:	Robert Oostenveld
URL:
Tags:
Depends on:
Blocks:	2285218621873285
See also:

Robert Oostenveld - 2017-04-21 14:08:06 +0200

Arjen implemented ft_append_sens and made changes to ft_append_data. This made the inconsistency between appending data/timelock/freq very obvious. Please note that there is also an ft_appendsource, but I won't be looking at that one now.

Robert Oostenveld - 2017-04-21 15:04:33 +0200

I started on a new (personal) branch. commit 7d972193ab5cbc26d07db8be358b0a72521d91e3 revamped the ft_appendtimelock and ft_appendfreq functions, see http://bugzilla.fieldtriptoolbox.org/show_bug.cgi?id=3287 the heavy lifting is now done by ft_selectdata, the append functions are only overlaying the data where it fits. I also updated and extended the test scripts. commit fd862ab56c5ec07878d9a78c9c1b7f440e7d79f1 changes to documentation and help, no functional changes commit 5a3b90b6ff15c3b85a23ff3f12c056378734555c added fields to ignore when appending data commit ab5659bfd13f52dafe1055f95c881268b06233c0 also support opto (besides grad and elec) commit f31b3cab4d55efd44e90b8c8954b24e81851165a small change in formatting of a comment

Arjen Stolk - 2017-04-24 18:44:10 +0200

For part of the discussion: https://github.com/robertoostenveld/fieldtrip/commit/42131f15c1c11d44ca5c2e9ad55f5e56c619d045#commitcomment-21875873

Robert Oostenveld - 2017-04-25 13:46:42 +0200

this has been resolved with https://github.com/fieldtrip/fieldtrip/pull/413

Robert Oostenveld - 2019-08-10 12:34:51 +0200

This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue on https://github.com/fieldtrip/fieldtrip/issues.