Back to the main page.
Bug 3308 - Generic syntax description with funname
| Status | CLOSED FIXED |
| Reported | 2017-06-13 14:10:00 +0200 |
| Modified | 2019-08-10 12:42:01 +0200 |
| Product: | FieldTrip |
| Component: | octave |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Linux |
| Importance: | P5 minor |
| Assigned to: | |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: | http://bugzilla.fieldtriptoolbox.org/show_bug.cgi?id=3258 |
Guillaume - 2017-06-13 14:10:33 +0200
I mentioned earlier in Bug 3258 that a number of functions throw a warning in Octave because they use a generic description: function [varargout] = funname(varargin) (e.g. lmoutr.m ltrisect.m plinproj.m ptriproj.m routlm.m solid_angle.m splint_gh.m) Would it be ok to make the relevant adjustment to use the actual function name and, if so, which ones are the 'master' files: the ones in the 'src' folder?
Robert Oostenveld - 2017-06-13 22:48:05 +0200
Hi Guillaume, I have fixed this with mac011> git commit -a [bug3309-checkcode 9da5640] ENH - use correct function name (see http://bugzilla.fieldtriptoolbox.org/show_bug.cgi?id=3308), updated test script to catch this type of error 78 files changed, 208 insertions(+), 80 deletions(-) which is in https://github.com/fieldtrip/fieldtrip/pull/455 There is not specifically one master, all copies are as important. The fieldtrip/bin/synchronize-private.sh script is used automatically (from a github web hook) to copy the latest changed version over any other version of the same file. If you want to be sure that all copies are updated, use synchronize-private.sh (on a linux/mac computer) prior to committing or testing.
Robert Oostenveld - 2019-08-10 12:35:47 +0200
This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue on https://github.com/fieldtrip/fieldtrip/issues.