Back to the main page.

Bug 3312 - Use gammaln instead of lgamma in betapdf.m

Status	CLOSED FIXED
Reported	2017-06-14 12:20:00 +0200
Modified	2019-08-10 12:41:13 +0200
Product:	FieldTrip
Component:	octave
Version:	unspecified
Hardware:	PC
Operating System:	Linux
Importance:	P5 minor
Assigned to:
URL:
Tags:
Depends on:
Blocks:
See also:

Guillaume - 2017-06-14 12:20:25 +0200

gammaln() should be called instead of lgamma() in external/stats/betapdf.m and compatibility function lgamma.m should be removed. This already took place in Octave from which the function is borrowed: http://hg.savannah.gnu.org/hgweb/octave/rev/653ed3a6ba83 This prevents the display of a warning in Octave "lgamma shadows a built-in function".

Robert Oostenveld - 2017-06-14 13:20:19 +0200

Hi Guillaume, If you want, you can just fork FT on github, pull a clone and make changes in that. If then send a pull-request, we can integrate it more quickly. See http://www.fieldtriptoolbox.org/development/git for an explanation (if you need that). Robert

Guillaume - 2017-06-14 13:37:44 +0200

Thanks, done in PR 459

Guillaume - 2017-06-16 17:29:03 +0200

Once lgamma.m is removed, ft_platform_supports.m should be updated not to list this file in 'exclude_mfiles' for 'stats'. Also, for compatibility with Octave, the second input argument to has_all_functions_in_dir() should be {} instead of [] (for 'images' and 'signal').

Robert Oostenveld - 2017-06-19 09:16:11 +0200

(In reply to Guillaume from comment #3) could you add these to https://github.com/fieldtrip/fieldtrip/pull/459 I'll then merge.

Jan-Mathijs Schoffelen - 2017-11-23 15:57:23 +0100

This seems to have been addressed

Robert Oostenveld - 2019-08-10 12:35:02 +0200

This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue on https://github.com/fieldtrip/fieldtrip/issues.