Back to the main page.
Bug 3314 - isequalwithequalnans is not recommended. Use ISEQUALN instead.
| Status | CLOSED FIXED |
| Reported | 2017-06-15 14:31:00 +0200 |
| Modified | 2017-11-20 20:08:35 +0100 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Mac OS |
| Importance: | P5 normal |
| Assigned to: | Jan-Mathijs Schoffelen |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Robert Oostenveld - 2017-06-15 14:31:51 +0200
all occurrences (and especially recently introduced ones) should be fixed.
Robert Oostenveld - 2017-06-15 14:32:41 +0200
see also https://github.com/fieldtrip/fieldtrip/pull/456
Roemer van der Meij - 2017-06-16 21:47:25 +0200
isequaln is only present in 2012a+ though. Several options: 1) don't use isequaln 2) use ft_platform_supports to switch between isequaln/withequalnans 3) write an overloading wrapper which uses ft_platform_supports
Jan-Mathijs Schoffelen - 2017-06-17 06:27:39 +0200
There is this 'rule' stating that we support matlab versions up to 5 years ago, so we are just fine if we use isequaln throughout. However, I see that fieldtrip/compat/matlablt2012a contains isequaln.m, which should take care of this for matlab versions that are lower than 2012a :o)
Jan-Mathijs Schoffelen - 2017-06-17 06:29:29 +0200
with a grep on isequalwithequalnans, there is: ft_sourceparcellate ft_sourcemovie and append_common that need to change.
Jan-Mathijs Schoffelen - 2017-06-17 06:34:37 +0200
I made the changes just now and created a PR: https://github.com/fieldtrip/fieldtrip/pull/463