Back to the main page.
Bug 3354 - sampleinfo should be updated after using ft_selectdata to make a latency selection on raw or timelocked data.
| Status | CLOSED FIXED |
| Reported | 2017-09-22 13:41:00 +0200 |
| Modified | 2018-03-02 15:05:12 +0100 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Mac OS |
| Importance: | P5 enhancement |
| Assigned to: | Jan-Mathijs Schoffelen |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Robert Oostenveld - 2017-09-22 13:41:13 +0200
It was noticed by Stefan (CC) that sampleinfo is dropped in this case. This happens around line 410 if avgovertime || ~isequal(cfg.latency, 'all') % these are invalid after averaging or making a latency selection keepfield = setdiff(keepfield, {'sampleinfo'}); end It would be nice to update sampleinfo rather than to drop it.
Jan-Mathijs Schoffelen - 2017-11-24 21:30:38 +0100
I have just made a PR that addresses this. Feel free to review it and comment.
Jan-Mathijs Schoffelen - 2017-12-07 09:03:05 +0100
PR merged, thus this has been addressed