Back to the main page.
Bug 3359 - plotting of bivariate data needs to be tested
| Status | CLOSED FIXED |
| Reported | 2017-10-05 13:15:00 +0200 |
| Modified | 2018-01-26 09:51:20 +0100 |
| Product: | FieldTrip |
| Component: | plotting |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Mac OS |
| Importance: | P5 normal |
| Assigned to: | Jan-Mathijs Schoffelen |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: | http://bugzilla.fieldtriptoolbox.org/show_bug.cgi?id=161 |
Robert Oostenveld - 2017-10-05 13:15:35 +0200
I noticed that with the large plotting overhaul, it failed for labelcmb data. The error was detected in test_old_ft_singleplotTFR.m I have made some changes to fix it.
Robert Oostenveld - 2017-10-05 13:19:56 +0200
mac011> git commit -a [bug3359 7c0d259] FIX - Completed the bivariate_common imple,entation, also for labelcmb. Fixed the plotting of markers and highlights. 4 files changed, 114 insertions(+), 91 deletions(-) https://github.com/fieldtrip/fieldtrip/pull/543 The code now runs through. I have the feeling that the highlight/marker code might still not be 100% perfect. The handling of chan_chan and chancmb dimensions in bidirectional data needs to be checked. Ideally there would be a test script with simulated/constructed data where it is clear how the directions work.
Jan-Mathijs Schoffelen - 2017-11-27 10:45:21 +0100
I wrote a test function that plots various representations of connectivity data (directed measure), using ft_topoplotER/ft_singleplotER. To me, all looks OK, including the highlighting. I have no reason to suspect any issues with TFR type data, and I won't spend time on this right now (since it also rarely occurs).