Back to the main page.

Bug 3429 - read_neuralynx_ncs directs to wrong mex file version

Status CLOSED INVALID
Reported 2018-05-28 14:43:00 +0200
Modified 2019-08-10 12:36:55 +0200
Product: FieldTrip
Component: external
Version: unspecified
Hardware: Macintosh
Operating System: Mac OS
Importance: P5 normal
Assigned to: Robert Oostenveld
URL:
Tags:
Depends on:
Blocks:
See also:

Stephen Whitmarsh - 2018-05-28 14:43:57 +0200

On line 55 the code (read_neuralynx_ncs.m) checks whether the Mac-compatible v3 of the neuralynx MATLAB library is on the path. However, it checks for v6 instead of v3. I assume this is an error? If so, please let me know and I'll make a PR. >>> original >>> elseif ismac || isunix % look for Ueli's libs only isMexv3 = ft_hastoolbox('neuralynx_v6', 2); % let's leave warnings for debug end >>> should be >>> elseif ismac || isunix % look for Ueli's libs only isMexv3 = ft_hastoolbox('neuralynx_v3', 2); % let's leave warnings for debug end Best, Stephen


Robert Oostenveld - 2018-05-29 16:59:21 +0200

you seem to be using an outdated version of the code. When looking at https://github.com/fieldtrip/fieldtrip/blob/79e6b4b954dcde665cb1d572e025c144e322b553/fileio/private/read_neuralynx_ncs.m#L55 I see this, which appears all fine. isMexv6 = false; isMexv3 = false; if ispc % first look for Neuralynx version 6 libs isMexv6 = ft_hastoolbox('neuralynx_v6', 2); % let's leave warnings for debug if ~isMexv6 % look for Ueli's libs as alternative isMexv3 = ft_hastoolbox('neuralynx_v3', 2); % let's leave warnings for debug end elseif ismac || isunix % look for Ueli's libs only isMexv3 = ft_hastoolbox('neuralynx_v3', 2); % let's leave warnings for debug end


Robert Oostenveld - 2019-08-10 12:36:55 +0200

This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue on https://github.com/fieldtrip/fieldtrip/issues.