Back to the main page.

Bug 526 - ft_freqdescriptive sets hasrpt if dimord contains 'subj', but errors later when no dimord does not contain 'rpt'

Reported 2011-03-10 10:08:00 +0100
Modified 2011-06-21 15:52:31 +0200
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P1 normal
Assigned to: Jörn M. Horschig
Depends on:
See also:

Jörn M. Horschig - 2011-03-10 10:08:59 +0100

summary says it all, I fixed it immediately using this: if hasrpt if ~strcmp(cfg.trials, 'all') % the following additional if-clause is what I added if ~isempty(strfind(freq.dimord, 'rpt')) freq = ft_selectdata(freq, 'rpt', cfg.trials); else % in case of grandaverage freq = ft_selectdata(freq, 'subj', cfg.trials); end; end; end; Please check if you agree

Jörn M. Horschig - 2011-03-10 10:10:43 +0100

btw, I will now work on ft_selectdata to support 'subj' tell me if I am doing something not in accordance to the FT-guidelines ;)

Jan-Mathijs Schoffelen - 2011-03-10 10:25:13 +0100

Would it be possible to deal with this at the level of ft_selectdata? I could imagine that a similar problem may also occur elsewhere. Rather than changing it at all those locations, changing only once would be preferred. JM

Jörn M. Horschig - 2011-03-10 10:55:04 +0100

dealt with by talking to JM will now be dealt with in selectdata instead, and I will not commit the change made to ft_freqdescriptives