Back to the main page.

Bug 630 - ft_databrowser redraws everything when marking new artifacts

Reported 2011-05-04 10:50:00 +0200
Modified 2011-09-14 14:33:27 +0200
Product: FieldTrip
Component: plotting
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P1 enhancement
Assigned to: Jörn M. Horschig
Depends on:
See also:

Jörn M. Horschig - 2011-05-04 10:50:29 +0200

the main purpose of this redrawing is to bring the artifact type to be marked in front (variable in code: ordervec - however, this does not mean that everything needs to be redrawn). for me, this is only apparent for component viewmode, but the same applies to the other two modi. suggested fix: - look at the case 'component' in the redraw function. There, I tagged the artifacts boxes, which can, once tagged, independently cleared from the rest of the figure: set(h, 'tag', 'artifacts'); [...] delete(findobj(h,'tag', 'artifacts')); ) where 'h' is the figure handle - implement the same tagging for the other viewmodes - change the actionlistener of the artifact buttons to call a new function 'clear artifact'. code to be implemented is essentially the same as in the beginning of the redraw function - note that this function might still need to distinguish the special case of 'component' viewmode, because the graphical onset of the time courses is different from 'butterfly' and 'vertical'

Jörn M. Horschig - 2011-05-04 11:45:01 +0200

small correction to how to tag handles: h_art = ft_plot_box(...) set(h_art, 'tag', 'artifacts') [...] delete(findobj(h,'tag', 'artifacts'));

Jan-Mathijs Schoffelen - 2011-06-15 15:16:58 +0200

is this still valid with the new code?

Jörn M. Horschig - 2011-06-16 22:19:15 +0200

I will have a look at all the databrowser bugs and see which ones are applicable. Since we did not change the code, just the structure, I would suppose the answer to your question to be 'yes'

Robert Oostenveld - 2011-09-14 14:33:27 +0200

I closed all the bugs that were in the status RESOLVED. This includes the ones that we just discussed in the weekly fieldtrip meeting, but also the bugs that we did not discuss.