Back to the main page.

Bug 649 - ft_sourceplot option cfg.inputcoordsys should be deprecated

Status CLOSED FIXED
Reported 2011-05-10 14:09:00 +0200
Modified 2011-06-15 15:08:59 +0200
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: Mac OS
Importance: P1 normal
Assigned to: Jan-Mathijs Schoffelen
URL:
Tags:
Depends on:
Blocks:
See also: http://bugzilla.fcdonders.nl/show_bug.cgi?id=650

Robert Oostenveld - 2011-05-10 14:09:07 +0200

% cfg.inputcoord = 'mni' or 'tal', coordinate system of data used to lookup the label from the atlas There should be a consistent cfg.coordsys option throughout all FT functions. Furthermore, the input data should preferably specify the coordinate system.


Robert Oostenveld - 2011-05-10 15:19:32 +0200

I added the cfg.coordsys and the cfg.units option as follows % ensure that the data has interpretable spatial units if ~isfield(data, 'unit') && ~isempty(cfg.units) data.unit = cfg.units; elseif ~isfield(data, 'unit') && isempty(cfg.units) data = ft_convert_units(data); elseif isfield(data, 'unit') && ~isempty(cfg.units) data = ft_convert_units(data, cfg.units); elseif isfield(data, 'unit') && isempty(cfg.units) % nothing to do end % ensure that the data has an interpretable coordinate system if ~isfield(data, 'coordsys') && ~isempty(cfg.coordsys) data.coordsys = cfg.coordsys; elseif ~isfield(data, 'coordsys') && isempty(cfg.coordsys) && ~isempty(cfg.atlas) % only needed if an atlas was specified for volumelookup data = ft_convert_coordsys(data); elseif isfield(data, 'coordsys') && ~isempty(cfg.coordsys) && ~isempty(cfg.atlas) % only needed if an atlas was specified for volumelookup data = ft_convert_coordsys(data, cfg.units); elseif isfield(data, 'coordsys') && isempty(cfg.coordsys) % nothing to do end Do you agree that this is how it should be?


Jan-Mathijs Schoffelen - 2011-06-10 10:24:30 +0200

I agree