Back to the main page.
Bug 721 - patch for rejectvisual_summary.m to visually show which trl/chan were removed
| Status | CLOSED FIXED |
| Reported | 2011-06-01 19:07:00 +0200 |
| Modified | 2011-06-15 15:09:09 +0200 |
| Product: | FieldTrip |
| Component: | plotting |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Mac OS |
| Importance: | P1 enhancement |
| Assigned to: | Jan-Mathijs Schoffelen |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Eliezer Kanal - 2011-06-01 19:07:00 +0200
Created attachment 62 svn diff output, using revision 3601 as base The rejectvisual_summary function UI seems to suggest that it should be used to *toggle* channels/trials, but as is the display only allows for the *rejection* of trials. This is due to two aspects of the function: 1) The plots do not show trials/channels that were turned off 2) The names of the removed trials/channels are not shown until the function is exited and the changes are saved. This patch adds the rejected trials back to the plot using a different plot style, so that the user can actually toggle the rejected trials/channels visually. The actual summary plot (the top left one) is redrawn every time without the rejected trials/channels.
Jan-Mathijs Schoffelen - 2011-06-02 20:48:01 +0200
Thanks for this one. As such the toggle functionality is nice. Yet, the advantage of the old way of displaying was that the scaling of the subplots was adjusted in order to reveal some finer detail. This is useful in case there are trials/channels for which the maximum value is several orders of magnitude bigger than the rest (e.g. squid jumps in meg-sensors, people specifying both meg and eeg channels to be displayed, or both meg gradiometers and magnetometers to be shown).
Eliezer Kanal - 2011-06-02 20:56:01 +0200
Thanks. I hear the point, and I considered it when submitting the patch. My thought was that people could simply run it twice to actually remove the points from the subpoints (run first time, select, let the function complete, and run again), but that does add work. I figured I'd submit it anyway to generate discussion.
Jan-Mathijs Schoffelen - 2011-06-03 10:20:33 +0200
My suggestion would then be to create a cfg-option (cfg.viewmode = 'remove' (default) or 'mark'). The 'remove' option will then be old behavior, the 'mark' option will give your suggested behavior. What do you think?
Eliezer Kanal - 2011-06-03 15:59:06 +0200
That sounds like a good way to implement this.