Back to the main page.

Bug 753 - ft_prepare_sourcemodel changes

Status CLOSED FIXED
Reported 2011-06-10 12:27:00 +0200
Modified 2011-06-22 14:17:57 +0200
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: Mac OS
Importance: P1 normal
Assigned to: Jan-Mathijs Schoffelen
URL:
Tags:
Depends on:
Blocks:
See also:

Jan-Mathijs Schoffelen - 2011-06-10 12:27:54 +0200

Created attachment 75 JM's changed file, but not yet committed to svn Hi both, I made a few changes to ft_prepare_sourcemodel (and tested it), but did not yet commit. I would appreciate your input: 1) cfg.mriunits is deprecated. If needed, it is estimated from the input mri 2) cfg.sourceunits is renamed into cfg.units + default behavior is slightly changed: if not specified, it defaults to 'auto', in which case it will use the units in the sensor-structure (at least: if the sensor structure is present). Otherwise, it defaults to 'cm' (which is old behavior) 3) the output grid will now contain a unit-field (if possible)


Cristiano Micheli - 2011-06-15 12:41:48 +0200

(In reply to comment #0) > Created attachment 75 [details] > JM's changed file, but not yet committed to svn > > Hi both, > > I made a few changes to ft_prepare_sourcemodel (and tested it), but did not yet > commit. I would appreciate your input: > > 1) cfg.mriunits is deprecated. If needed, it is estimated from the input mri > 2) cfg.sourceunits is renamed into cfg.units + default behavior is slightly > changed: > > if not specified, it defaults to 'auto', in which case it will use the units > in the sensor-structure (at least: if the sensor structure is present). > Otherwise, it defaults to 'cm' (which is old behavior) > > 3) the output grid will now contain a unit-field (if possible) To me it looks good!


Jan-Mathijs Schoffelen - 2011-06-15 15:51:35 +0200

changes committed, reverted cfg.units to cfg.sourceunits and sent off a message to the discussion list