Back to the main page.
Bug 784 - UI update to ft_rejectartifact
| Status | CLOSED FIXED |
| Reported | 2011-06-28 23:38:00 +0200 |
| Modified | 2011-07-13 14:19:56 +0200 |
| Product: | FieldTrip |
| Component: | preproc |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Mac OS |
| Importance: | P1 enhancement |
| Assigned to: | Eelke Spaak |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Eliezer Kanal - 2011-06-28 23:38:04 +0200
Created attachment 80 diff for patch Enhancement code submission; one annoyance I've come across in ft_rejectartifact is that when I get to the end of the trials it takes me one or two clicks of the mouse on the "good>" button before I realize I'm looking at the same trial over and over again. In that vein, I'm submitting this patch. It does two things: 1) dim the "<", "<<", ">>'', and ">" buttons when appropriate (based on info.trlop and info.ntrl) 2) dim the "good>" and "bad>" buttons if they were used to set the status of the last trial Point 2 is accomplished by recording the last viewed trial and seeing if the last viewed trial is the same as the current one. Most of the changes are incorporating the info.ltrlop (last trial) parameter into the code.
Eliezer Kanal - 2011-06-28 23:49:35 +0200
Created attachment 81 patch for proposed changes
Eliezer Kanal - 2011-06-28 23:50:29 +0200
Updated patch, now applies to keypresses also. Sorry for so many emails, still getting used to bugzilla's interface.
Eelke Spaak - 2011-06-29 08:41:48 +0200
Thanks for the patch. Just to be sure: I guess this is for ft_reject*visual*, rather than ft_reject*artifact*, right? ft_rejectartifact does not have a GUI :)
Robert Oostenveld - 2011-06-29 13:56:38 +0200
I patched, tested and committed the your suggestion. Can you please also do it for cfg.method=channel, i.e. not browse before first channel? Btw. I was surprised about the nice graphical display of the patch in bugzilla!
Eliezer Kanal - 2011-06-29 14:47:50 +0200
(In reply to comment #3) > Thanks for the patch. Just to be sure: I guess this is for ft_reject*visual*, > rather than ft_reject*artifact*, right? ft_rejectartifact does not have a GUI > :) Yes, sorry, that's right. (In reply to comment #4) > I patched, tested and committed the your suggestion. > > Can you please also do it for cfg.method=channel, i.e. not browse before first > channel? > > Btw. I was surprised about the nice graphical display of the patch in bugzilla! I plan on doing this one today. Also, I had a few ideas for improving the rejectsummary as well, including allowing the metric to be changed using radio buttons. If I get that working I'll submit a new bug report with patch.
Eliezer Kanal - 2011-06-29 16:55:46 +0200
Created attachment 84 same change, for rejectvisual_channel Here's the same change, but for rejectvisual_channel.