Back to the main page.
Bug 951 - the main plotting functions have inconsistent return values
| Status | CLOSED FIXED |
| Reported | 2011-09-12 11:41:00 +0200 |
| Modified | 2012-02-03 21:53:18 +0100 |
| Product: | FieldTrip |
| Component: | plotting |
| Version: | unspecified |
| Hardware: | All |
| Operating System: | All |
| Importance: | P1 enhancement |
| Assigned to: | Boris Reuderink |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | 1142 |
| See also: |
Robert Oostenveld - 2011-09-12 11:41:52 +0200
Some return the cfg, some a handle, some nothing. This should be discussed at the FT meeting. manzana> head -1 ft*plot* ==> ft_clusterplot.m <== function ft_clusterplot(cfg, stat) ==> ft_connectivityplot.m <== function h = ft_connectivityplot(cfg, varargin) ==> ft_headmodelplot.m <== function [cfg] = ft_headmodelplot(cfg, data) ==> ft_layoutplot.m <== function ft_layoutplot(cfg, data) ==> ft_movieplotER.m <== function ft_movieplotER(cfg, timelock) ==> ft_multiplotCC.m <== function ft_multiplotCC(cfg, data) ==> ft_multiplotER.m <== function [cfg] = ft_multiplotER(cfg, varargin) ==> ft_multiplotTFR.m <== function [cfg] = ft_multiplotTFR(cfg, data) ==> ft_neighbourplot.m <== function ft_neighbourplot(cfg, data) ==> ft_singleplotER.m <== function [cfg] = ft_singleplotER(cfg, varargin) ==> ft_singleplotTFR.m <== function [cfg] = ft_singleplotTFR(cfg, data) ==> ft_sourceplot.m <== function [cfg] = ft_sourceplot(cfg, data) ==> ft_spike_plot_isi.m <== function [H] = ft_spike_plot_isih(cfg,isih) ==> ft_spike_plot_isireturn.m <== function [hdl] = ft_spike_plot_isireturn(cfg,isih) ==> ft_spike_plot_jpsth.m <== function [H] = plot_jpsth(cfg,jpsth) ==> ft_spike_plot_psth.m <== function [hdl] = ft_spike_plot_psth(cfg,psth) ==> ft_spike_plot_raster.m <== function [hdl] = ft_spike_plot_raster(cfg, spike) ==> ft_topoplotCC.m <== function cfg = ft_topoplotCC(cfg, freq) ==> ft_topoplotER.m <== function [cfg] = ft_topoplotER(cfg, varargin) ==> ft_topoplotIC.m <== function [cfg] = ft_topoplotIC(cfg, varargin) ==> ft_topoplotTFR.m <== function [cfg] = ft_topoplotTFR(cfg, varargin)
Jan-Mathijs Schoffelen - 2011-09-14 11:16:09 +0200
*** Bug 926 has been marked as a duplicate of this bug. ***
Boris Reuderink - 2011-11-14 23:09:42 +0100
What was decided in the FT meeting?
Robert Oostenveld - 2011-11-15 09:13:16 +0100
(In reply to comment #2) > What was decided in the FT meeting? has not yet been discussed.
Boris Reuderink - 2011-11-17 10:46:34 +0100
Changed the status of bugs without a specific owner to UNCONFIRMED. I'll try to replicate these bugs (potentially involving the submitter), and change confirmed bugs to NEW. Boris
Robert Oostenveld - 2011-12-07 11:27:17 +0100
this was discussed in last weeks FT meeting. It was decided taht all plotting functions should return the plotting cfg, with in that cfg also the cfg.previous of the input data.
Robert Oostenveld - 2011-12-07 11:27:42 +0100
I have just changed all ft*plot* functions into function [cfg] = ft_clusterplot(cfg, stat) function [cfg] = ft_connectivityplot(cfg, varargin) function [cfg] = ft_headmodelplot(cfg, data) function [cfg] = ft_layoutplot(cfg, data) function [cfg] = ft_movieplotER(cfg, data) function [cfg] = ft_movieplotTFR(cfg, data) function [cfg] = ft_multiplotCC(cfg, data) function [cfg] = ft_multiplotER(cfg, varargin) function [cfg] = ft_multiplotTFR(cfg, data) function [cfg] = ft_neighbourplot(cfg, data) function [cfg] = ft_singleplotER(cfg, varargin) function [cfg] = ft_singleplotTFR(cfg, data) function [cfg] = ft_sourceplot(cfg, data) function [cfg] = ft_spike_plot_isi(cfg, isih) function [cfg] = ft_spike_plot_isireturn(cfg, isih) function [cfg] = ft_spike_plot_jpsth(cfg, jpsth) function [cfg] = ft_spike_plot_jpsth(cfg, jpsth) function [cfg] = ft_spike_plot_psth(cfg, psth) function [cfg] = ft_spike_plot_raster(cfg, spike) function [cfg] = ft_topoplotCC(cfg, freq) function [cfg] = ft_topoplotER(cfg, varargin) function [cfg] = ft_topoplotIC(cfg, varargin) function [cfg] = ft_topoplotTFR(cfg, varargin)
Martin Vinck - 2011-12-07 11:29:09 +0100
So, where do you put the figure handles then?
Robert Oostenveld - 2011-12-07 11:42:50 +0100
also ensured that they have the proper callinfo and other pre- and postambles. manzana> svn commit ft*plot*m Sending ft_clusterplot.m Sending ft_connectivityplot.m Sending ft_headmodelplot.m Sending ft_layoutplot.m Sending ft_movieplotER.m Sending ft_movieplotTFR.m Sending ft_multiplotCC.m Sending ft_neighbourplot.m Sending ft_singleplotTFR.m Sending ft_spike_plot_isi.m Sending ft_spike_plot_isireturn.m Sending ft_spike_plot_jpsth.m Sending ft_spike_plot_psth.m Sending ft_spike_plot_raster.m Sending ft_topoplotCC.m Sending ft_topoplotER.m Sending ft_topoplotIC.m Transmitting file data ................. Committed revision 4941.
Robert Oostenveld - 2011-12-07 11:50:07 +0100
(In reply to comment #7) this has been sorted out over skype.