Back to the main page.

Bug 961 - new config option confusion in ft_artifact_ecg

Status CLOSED FIXED
Reported 2011-09-14 15:05:00 +0200
Modified 2011-10-04 13:49:05 +0200
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P1 normal
Assigned to: Johanna
URL:
Tags:
Depends on:
Blocks:
See also:

Johanna - 2011-09-14 15:05:05 +0200

In the new 'help' documentation, cfg.artfctdef.ecg.interactive was added, but in the code it was named cfg.artfctdef.ecg.feedback, hence leading to a crash as the user doesn't know to specify the feedback option based on help documentation. It seems in this case it is an 'interactive' rather than 'feedback' so I will change the code to match the documentation (calling it .interactive).


Johanna - 2011-09-14 15:08:28 +0200

Sorry, I mean that 'interactive' was already accounted for in the if ~isfield(...) section, so I will change later mention of .feedback to .interactive, as well as add .interactive to the help at the top (saying that 'yes' is default).


Robert Oostenveld - 2011-09-14 15:14:49 +0200

sorry about the confusion. I needed the option to be able to do test_ft_artifact_xxx without the user interaction. Please make the option and/or documentation consistent with whatever is done in zvalue (and please check that test_ft_artifact_xxx still runs).


Johanna - 2011-09-14 16:21:10 +0200

ft_artifact_zvalue uses 'feedback' so I'll set *ecg to use the same (not 'interactive'). and test_ft_artifact_xxx still runs fine.